Opened 7 years ago
Closed 7 years ago
#17929 closed enhancement (fixed)
Ref: add various missing modules to r/categories
Reported by:  mmezzarobba  Owned by:  

Priority:  major  Milestone:  sage6.6 
Component:  documentation  Keywords:  reference, categories 
Cc:  Merged in:  
Authors:  Marc Mezzarobba  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  868f91a (Commits, GitHub, GitLab)  Commit:  868f91ac209798b1e11a416924fc4cf88277090a 
Dependencies:  Stopgaps: 
Description (last modified by )
Add various missing modules to the Categories part of the reference manual.
Change History (15)
comment:1 Changed 7 years ago by
 Cc reference categories removed
 Description modified (diff)
 Keywords reference categories added
comment:2 Changed 7 years ago by
 Status changed from new to needs_review
comment:3 followup: ↓ 4 Changed 7 years ago by
 Branch changed from u/mmezzarobba/refcategories to public/17929
 Commit changed from 8581a54a1ddc1f1ad0bd76466b9c43dd7dcf43a9 to b0ed656a99cd5692ab0f19443f49cddb3e5b42c2
comment:4 in reply to: ↑ 3 Changed 7 years ago by
Replying to chapoton:
Here is a commit correcting just a few details in the doc of the added modules.
Thanks!
Why did not you add
discrete_valuation
andpoor_man_map
?
I meant to; I guess I must have forgotten to save my changes at some point, or something like that.
Edit: fixed, untested.
comment:5 Changed 7 years ago by
 Commit changed from b0ed656a99cd5692ab0f19443f49cddb3e5b42c2 to 97960cf120af688990548d90943584ce9596bc6c
Branch pushed to git repo; I updated commit sha1. New commits:
97960cf  Ref: more missing modules in r/categories

comment:6 Changed 7 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
ok, looks good to me.
comment:7 Changed 7 years ago by
 Status changed from positive_review to needs_work
oh, one last thing : sort by alphabetical order !
comment:8 Changed 7 years ago by
 Commit changed from 97960cf120af688990548d90943584ce9596bc6c to 3865efff3a2739aeaff64d93b54c7855a647e6ea
Branch pushed to git repo; I updated commit sha1. New commits:
3865eff  sort

comment:10 followup: ↓ 11 Changed 7 years ago by
 Status changed from positive_review to needs_work
PDF docs fail to build
comment:11 in reply to: ↑ 10 Changed 7 years ago by
Replying to vbraun:
PDF docs fail to build
Sorry, I thought the pdf reference manual was more or less abandoned. Thanks for the notice.
comment:12 Changed 7 years ago by
 Commit changed from 3865efff3a2739aeaff64d93b54c7855a647e6ea to 868f91ac209798b1e11a416924fc4cf88277090a
Branch pushed to git repo; I updated commit sha1. New commits:
868f91a  trac #17929 make sure pdf doc builds

comment:13 Changed 7 years ago by
The point of the pdf reference is of course not to print it out but to ensure that the markup is valid (so you don't end up with broken mathjax warning when you look at it in the browser).
comment:14 Changed 7 years ago by
 Status changed from needs_work to positive_review
PDF doc now builds
comment:15 Changed 7 years ago by
 Branch changed from public/17929 to 868f91ac209798b1e11a416924fc4cf88277090a
 Resolution set to fixed
 Status changed from positive_review to closed
Here is a commit correcting just a few details in the doc of the added modules.
Why did not you add
discrete_valuation
andpoor_man_map
?New commits:
trac #17929 a few fixes in the added modules